Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation layer and upgrade path for QueryBuilder::reset*() methods #6193

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Add deprecation layer and upgrade path for QueryBuilder::reset*() methods #6193

merged 1 commit into from
Oct 15, 2023

Conversation

derrabus
Copy link
Member

Q A
Type improvement
Fixed issues #6186

Summary

This PR adds the missing deprecation layer for the QueryBuilder::resetQueryParts() and QueryBuilder::resetQueryPart() methods that had been removed from the 4.0.x branch already. Following the discussion in #6186 and the work done in #6190, some replacements have been put in place.

@derrabus derrabus added this to the 3.8.0 milestone Oct 15, 2023
@derrabus derrabus mentioned this pull request Oct 15, 2023
Closed
@derrabus derrabus force-pushed the improvement/query-builder-reset branch from b996223 to d00d45a Compare October 15, 2023 11:58
@derrabus derrabus requested a review from morozov October 15, 2023 12:19
@derrabus
Copy link
Member Author

AppVeyor failure looks unrelated.

@greg0ire greg0ire merged commit 29aafaf into doctrine:3.8.x Oct 15, 2023
84 checks passed
@greg0ire
Copy link
Member

Thanks @derrabus !

@derrabus derrabus deleted the improvement/query-builder-reset branch October 15, 2023 21:00
@derrabus derrabus mentioned this pull request Oct 15, 2023
Merged
derrabus added a commit that referenced this pull request Oct 15, 2023
@derrabus
Replace TODO with proper PR link (#6195)
e9ede0c 
|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | Follows #6193

#### Summary

Classic. Usually, @greg0ire finds those things in his review. But not
today. 😬
@mollux mollux mentioned this pull request Feb 5, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Deprecation New Feature
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @greg0ire @morozov